Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #836: Use releaseName to get release info. #855

Merged
merged 1 commit into from Jul 26, 2018

Conversation

@johnmshields
Copy link
Contributor

johnmshields commented Jul 26, 2018

The helm release name can be templated so within the deployRelease
function the releaseName variable should be used any time the release
name is desired.

This commit updates the final call to getDeployResults to properly use
the releaseName variable.

#836

The helm release name can be templated so within the `deployRelease`
function the `releaseName` variable should be used any time the release
name is desired.

This commit updates the final call to `getDeployResults` to properly use
the `releaseName` variable.
Copy link
Member

dgageot left a comment

LGTM

@dgageot

This comment has been minimized.

Copy link
Member

dgageot commented Jul 26, 2018

@johnmshields awesome job. Thanks!

@dgageot dgageot merged commit e85d362 into GoogleContainerTools:master Jul 26, 2018
4 checks passed
4 checks passed
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kokoro CI build successful.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.