Fix firebase collection regressions #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdata
force-pushed
the
fix-firebase-collection-regressions
branch
2 times, most recently
from
7ae716f to
aa5dd6e
Compare
Contributor
Author
|
@robdodson @kevinpschaaf This has received a major update. PTanotherL! |
firebase-collection.html
Outdated
Member
There was a problem hiding this comment.
then this._warn is more appropriate, maybe?
cdata
force-pushed
the
fix-firebase-collection-regressions
branch
3 times, most recently
from
bba68f8 to
7790733
Compare
Contributor
Author
|
I've responded to your feedback @kevinpschaaf - PT(yet)anotherL! |
Member
There was a problem hiding this comment.
Clear _lastLocallyAddedIndex at end of loop
Member
|
Otherwise, LGTM |
cdata
force-pushed
the
fix-firebase-collection-regressions
branch
from
7790733 to
b4dd34c
Compare
cdata
added a commit
that referenced
this pull request
Oct 16, 2015
…on-regressions Fix firebase collection regressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the
v1.0.3 -> v1.0.4"guard local changes" patch, and adds an alternative fix for the failing tests.This should also fix the same things as #62