Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add asqlite sql adapter. #210

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Add asqlite sql adapter. #210

merged 1 commit into from
Oct 14, 2023

Conversation

fretgfr
Copy link
Contributor

@fretgfr fretgfr commented Sep 2, 2023

Rationale

Beneficial to people that use sqlite for a database via Danny's asqlite library.

Summary of changes made

Adds an adapter for asqlite connections and pools.

Checklist

  • This PR changes the jishaku module/cog codebase
    • These changes add new functionality to the module/cog
    • These changes fix an issue or bug in the module/cog
    • I have tested that these changes work on a production bot codebase
    • I have tested these changes against the CI/CD test suite
    • I have updated the documentation to reflect these changes
  • This PR changes the CI/CD test suite
    • I have tested my suite changes are well-formed (all tests can be discovered)
    • These changes adjust existing test cases
    • These changes add new test cases
  • This PR changes prose (such as the documentation, README or other Markdown/RST documents)
    • I have proofread my changes for grammar and spelling issues
    • I have tested that any changes regarding Markdown/RST syntax result in a well formed document

@Gorialis Gorialis merged commit f1054d8 into Gorialis:master Oct 14, 2023
@Gorialis Gorialis mentioned this pull request Nov 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fretgfr @Gorialis