Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate import_expression logic into jishaku. #231

Closed
wants to merge 6 commits into from
Closed

Incorporate import_expression logic into jishaku. #231

wants to merge 6 commits into from

Commits on Apr 14, 2024

  1. Initial work. 

    - Modify logic from Sachaa-Thanasius/experimental.
- Copy modified tests.
- Substitute import_expression.parse with inline_import.parse.
- Remove IMPORTER.
    @Sachaa-Thanasius
    Sachaa-Thanasius committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    3c92d37 View commit details
    Browse the repository at this point in the history

  2. Fix a 3.8 bug and adjust style. 

    - Fix test break, since `tokenize.tokenize` has buggy behavior that wasn't backported.
 - See python/cpython#79288 and python/cpython#88833.
- Adjust typing using so everything from typing is prepended with `typing.`.
    @Sachaa-Thanasius
    Sachaa-Thanasius committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    d285201 View commit details
    Browse the repository at this point in the history

  3. Add a test for the 3.8 newline token issue.

    @Sachaa-Thanasius
    Sachaa-Thanasius committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    fc395b0 View commit details
    Browse the repository at this point in the history

  4. Run isort

    @Sachaa-Thanasius
    Sachaa-Thanasius committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    347936e View commit details
    Browse the repository at this point in the history

  5. Fixed missing newline and removed debug code.

    @Sachaa-Thanasius
    Sachaa-Thanasius committed Apr 14, 2024
    Configuration menu
    Copy the full SHA
    cd86fab View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Adjust copy_annotations() helper and typing_extensions imports. 

    - `typing_extensions` is a direct dependency, so using it directly is fine.
- `copy_annotations()` was using functools.wraps with the wrong function as the wrapper.
    @Sachaa-Thanasius
    Sachaa-Thanasius committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    675b307 View commit details
    Browse the repository at this point in the history