[TD-135] Support illumos (non gnu-which) in PKI scripts

[taskwarrior]

Thomas on 2017-08-27T10:51:56Z says:

The which command is different on all operating system from Linux to *BSD and illumos (SunOS). For that reason the following command result in an error:
{code:java}
CERTTOOL=$(which gnutls-certtool || which certtool){code}
Because which on illumos always output the lookup path at stdout.
{code:java}
$ CERTTOOL=$(which gnutls-certtool || which certtool)
$ echo ${CERTTOOL}
no gnutls-certtool in /usr/local/sbin /usr/local/bin /opt/local/sbin /opt/local/bin /usr/sbin /usr/bin /sbin /opt/local/bin/certtool{code}
 Affected shell scripts:

• pki/generate.ca
• pki/generate.client
• pki/generate.crl
• pki/generate.server

Recommendation:

 Replace which with type -p or create a full if-query with output redirection.

[taskwarrior]

Migrated metadata:

Created: 2017-08-27T10:51:56Z
Modified: 2017-12-10T04:43:29Z

[taskwarrior]

Paul Beckingham on 2017-10-12T02:43:08Z says:

Send a (portable) patch.

[taskwarrior]

Thomas on 2017-10-13T11:17:35Z says:

I've attached attached a patch ( [^0001-Posix-compatibility-for-pki-shell-scripts.patch] ) which provide the most portable and POSIX compatibility. If you have any question feel free to contact me.

[taskwarrior]

Paul Beckingham on 2017-12-10T04:43:29Z says:

This patch was generated against either the master or 1.1.0 branch (same thing) and is already released.  The development branch is 1.2.0, which already has this kind of portability fix on it.

[pbeckingham]

TD-135_0001-Posix-compatibility-for-pki-shell-scripts.patch.txt