New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TW-1935] Separate verbosity category for rc overrides #1947

Closed
taskwarrior opened this Issue Feb 14, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@taskwarrior
Contributor

taskwarrior commented Feb 14, 2018

Paul Fenwick on 2017-11-23T21:13:52Z says:

Summary

"Configuration override..." messages would be even better with their own verbosity category.

User Story

I have TaskWarrior integrated into my shell-prompt, to let me know when I have important tasks (over-)due. I turn off hooks when TaskWarrior runs as part of my prompt by using rc.hooks=off, however this means I get messages for every prompt telling me I've done this:

{code}
Configuration override rc.hooks:off
{code}

I can override this by using rc.verbose=nothing rc.hooks=off, but then I don't get messages when tasks un-wait themselves, and I really want these as they're a primary way that I start doing things.

I could use rc.verbose=unwait, but that implies rc.verbose=footnote, which means I get the configuration override messages again. So I have to choose between missing tasks unwaiting themselves, or getting extra config messages I'm not after.

Having hooks off by default and turning them on in my t alias doesn't help here either, because I don't want to see the config override messages then, either.

This ticket is me wish-listing that config override messages had their own verbosity category, so I can have footnotes turned on, but override messages turned off. :)

@taskwarrior taskwarrior added this to the 2.6.0 milestone Feb 14, 2018

@taskwarrior

This comment has been minimized.

Contributor

taskwarrior commented Feb 14, 2018

Migrated metadata:

Created: 2017-11-23T21:13:52Z
Modified: 2017-12-02T18:08:28Z
@taskwarrior

This comment has been minimized.

Contributor

taskwarrior commented Feb 14, 2018

Paul Fenwick on 2017-11-24T17:45:16Z says:

Update: I have a patch, but my day is filled with many hours of flights, so it may take ~24hrs before I can send in a PR. :)

@taskwarrior

This comment has been minimized.

Contributor

taskwarrior commented Feb 14, 2018

Paul Fenwick on 2017-11-26T23:14:04Z says:

Patches attached!

  • The first just adds some in-line documentation, with no code changes. I wrote it for myself while figuring out how things work. Totally optional.
  • The second adds an override verbosity, which implies footnote. This controls whether Configuration override rc...messages get displayed. It's enabled by default, and has no impact on overrides from environment variables, as they happen while the context is being constructed.
  • The third just adds some vim hints. Again, totally optional.

I'm running this locally and it's working great, but happy to take requests for adjustments if desired.

~ Paul

@taskwarrior

This comment has been minimized.

Contributor

taskwarrior commented Feb 14, 2018

Paul Beckingham on 2017-12-02T18:08:28Z says:

Patches applied and pushed.  Thank you.  Nice improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment