Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entering an escaped quote in a tag name causes incorrect JSON to be generated #138

Closed
bognolo opened this issue May 8, 2018 · 0 comments · Fixed by #143
Closed

Entering an escaped quote in a tag name causes incorrect JSON to be generated #138

bognolo opened this issue May 8, 2018 · 0 comments · Fixed by #143
Assignees
Labels
bug Something isn't working
Milestone

Comments

@bognolo
Copy link

bognolo commented May 8, 2018

Note that the issue is only in the JSON generation, the data is correctly escaped in the database and the standard output including summary

$ timew start "This is a very long tag indeed\";01"
Tracking "This is a very long tag indeed\";01"
  Started 2018-05-08T11:45:22
  Current                  22
  Total               0:00:00

$ timew 
Tracking "This is a very long tag indeed\";01"
  Started 2018-05-08T11:45:22
  Current               47:19
  Total               0:01:57

$ timew summary :week
Wk  Date       Day Tags                                  Start      End    Time   Total
W19 2018-05-07 Mon task1                              15:24:32 15:30:00 0:05:28
                   task2                              15:30:21 15:39:38 0:09:17 0:14:45
W19 2018-05-08 Tue test1                              10:16:04 11:05:19 0:49:15
                   test1                              11:05:29 11:30:17 0:24:48
                   task1                              11:30:17 11:42:37 0:12:20
                   task1                              11:43:14 11:44:58 0:01:44
                   This is a very long tag indeed";01 11:45:22 11:48:17 0:02:55
                   This is a very long tag indeed';01 11:48:30        - 0:08:01 1:39:03
                                                                                       
                                                                                1:53:48

$ timew get dom.active.json
{"start":"20180508T014522Z","tags":["This is a very long tag indeed";01"]}
@lauft lauft self-assigned this May 10, 2018
lauft added a commit that referenced this issue May 11, 2018
lauft added a commit that referenced this issue May 11, 2018
@lauft lauft added the bug Something isn't working label May 11, 2018
@lauft lauft added this to the 1.2.0 milestone May 11, 2018
lauft added a commit that referenced this issue May 11, 2018
lauft added a commit that referenced this issue May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants