New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TI-58] Delete command is not always deleting #63

Closed
taskwarrior opened this Issue Feb 11, 2018 · 5 comments

Comments

Projects
None yet
1 participant
@taskwarrior

taskwarrior commented Feb 11, 2018

Paul Beckingham on 2017-01-13T14:44:26Z says:

lynoure(at)SophieGermain:~$ timew summary :ids

Wk Date       Day ID Tags         Start      End    Time   Total
W2 2017-01-13 Fri @3 usertools 10:01:34 12:30:00 2:28:26
                 @2 usertools 13:00:00 14:36:55 1:36:55
                 @1 usertools 15:13:17 15:26:48 0:13:31 4:18:52
                                                               
                                                        4:18:52

lynoure(at)SophieGermain:~$ timew lengthen @3 29min
You cannot overlap intervals. Correct the start/end time, or specify the :adjust hint.
lynoure(at)SophieGermain:~$ timew merge @2 @3
There is no active time tracking.
lynoure(at)SophieGermain:~$ timew join @2 @3     
You cannot overlap intervals. Correct the start/end time, or specify the :adjust hint.
lynoure(at)SophieGermain:~$ timew join @2 @3 :adjust
Joined @2 and @3

lynoure(at)SophieGermain:~$ timew summary :ids

Wk Date       Day ID Tags         Start      End    Time   Total
W2 2017-01-13 Fri @5 usertools 10:01:34 12:30:00 2:28:26
                 @4 usertools 13:00:00 14:36:55 1:36:55
                 @3 usertools 10:01:34 12:30:00 2:28:26
                 @2 usertools 13:00:00 14:36:55 1:36:55
                 @1 usertools 15:13:17 15:26:48 0:13:31 8:24:13
                                                               
                                                        8:24:13

lynoure(at)SophieGermain:~$ timew delete @4
Deleted @4
lynoure(at)SophieGermain:~$ timew summary :ids

Wk Date       Day ID Tags         Start      End    Time   Total
W2 2017-01-13 Fri @5 usertools 10:01:34 12:30:00 2:28:26
                 @4 usertools 13:00:00 14:36:55 1:36:55
                 @3 usertools 10:01:34 12:30:00 2:28:26
                 @2 usertools 13:00:00 14:36:55 1:36:55
                 @1 usertools 15:13:17 15:26:48 0:13:31 8:24:13
                                                               
                                                        8:24:13

Thanks to Lynoure.

@taskwarrior taskwarrior added this to the 1.1.0 milestone Feb 11, 2018

@taskwarrior

This comment has been minimized.

taskwarrior commented Feb 11, 2018

Migrated metadata:

Created: 2017-01-13T14:44:26Z
Modified: 2017-04-05T21:11:08Z
@taskwarrior

This comment has been minimized.

taskwarrior commented Feb 11, 2018

Paul Beckingham on 2017-01-13T14:51:37Z says:

Sample data from above:

inc 20170113T090134Z - 20170113T133655Z # usertools
inc 20170113T090134Z - 20170113T133655Z # usertools
inc 20170113T141317Z - 20170113T142648Z # usertools
@taskwarrior

This comment has been minimized.

taskwarrior commented Feb 11, 2018

Paul Beckingham on 2017-02-23T21:25:18Z says:

Added test in test/delete.t

Thanks to asmyers.

@taskwarrior

This comment has been minimized.

taskwarrior commented Feb 11, 2018

Thomas Lauf on 2017-03-10T13:50:29Z says:

timew summary is lying about the ids. A honest display would be

{code}
Wk Date Day ID Tags Start End Time Total
W2 2017-01-13 Fri @3 usertools 10:01:34 12:30:00 2:28:26
@3 usertools 13:00:00 14:36:55 1:36:55
@2 usertools 10:01:34 12:30:00 2:28:26
@2 usertools 13:00:00 14:36:55 1:36:55
@1 usertools 15:13:17 15:26:48 0:13:31 8:24:13

                                                     8:24:13

{code}

The question is, what does an id reference? The interval stored in the datafile? The interval after applying exclusions? Currently, timew summary does the latter, however timew delete serializes the referenced interval, searches it in the datafile and fails, because this interval does not exist there.

@taskwarrior

This comment has been minimized.

taskwarrior commented Feb 11, 2018

Thomas Lauf on 2017-04-05T21:11:08Z says:

Synthetic intervals are now converted to real intervals and written to the database if a delete affects one of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment