Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update package.json #75

Merged
merged 2 commits into from May 8, 2020
Merged

update package.json #75

merged 2 commits into from May 8, 2020

Conversation

zhangwinning
Copy link
Contributor

@zhangwinning zhangwinning commented May 8, 2020 •
edited

check package.json, so update it.

Checking /Volumes/liyao/events/package.json
[====================] 5/5 100%

 airtap   ^1.0.0  →  ^3.0.0 
 isarray  ^2.0.2  →  ^2.0.5 
 tape     ^4.8.0  →  ^5.0.0

goto-bus-stop
goto-bus-stop requested changes May 8, 2020
View reviewed changes
Copy link
Member

@goto-bus-stop goto-bus-stop left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The airtap upgrade breaks our test suite in IE9 so we can't do that. Upgrading tape will be good, though. Could you revert the airtap upgrade?

package.json Outdated Show resolved Hide resolved
goto-bus-stop
goto-bus-stop approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@goto-bus-stop goto-bus-stop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 🎉

@goto-bus-stop goto-bus-stop merged commit 2686023 into browserify:master May 8, 2020
@zhangwinning zhangwinning deleted the update-package branch May 9, 2020 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goto-bus-stop goto-bus-stop goto-bus-stop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhangwinning @goto-bus-stop