ssl support #2

Open
mzu opened this Issue Oct 3, 2011 · 2 comments

Comments

Projects
None yet
2 participants

mzu commented Oct 3, 2011

Hi! Just started playing with jetpack-io.

It would be great if the API could offer ssl support (since this is already supported by the underlying TransportService -> @see https://developer.mozilla.org/en/XPCOM_Interface_Reference/nsISocketTransportService#createTransport() ). Should be easy to implement?

I guess if you like to mirror the node.js API, you would need a separate tsl/ssl module which could share the code from your net module by simply passing in the correct aSocketTypes when calling nsISocketTransportService#createTransport() ?

Owner

Gozala commented Oct 4, 2011

@mzu I use default value on createTransport which I believe is smart enough to guess from server if it's ssl, starttls, or udp. I guess it should be easy to implement (tls)[http://nodejs.org/docs/v0.5.8/api/tls.html#s_tls.connect] module from node if you derive from Socket and override connect so that the right aSocketTypes is used.

Since I don't have a tests / use case / time to do that it's not wont be high priority on my list, but you're more then welcome to send a pull request & I'll take time to review and pull in.

Hope this helps!

mzu commented Oct 6, 2011

OK, thanks. Same restrictions in terms of available time at the moment. But might be able to help in a few weeks...

@mzu mzu closed this Oct 6, 2011

@mzu mzu reopened this Oct 6, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment