Add Lightbox to photos.html #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You know, if you hadn't said "Take a look and tell me your thoughts" then I would've just merged it w/o looking... But no, you had to go and make active participation mandatory. |
|
Seems fine enough to me. |
imhaleyfyi
added a commit
that referenced
this pull request
Dec 13, 2013
Add Lightbox to photos.html
|
Ok, now, I'm not sure if you were being sarcastic or not (really, that could've gone either way), but I said that specifically for that purpose. I don't want you to just merge my code trusting that I did something that works/looks good - this is your project.... as much as I want to be a part of it ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went ahead and added Lightbox 2 to photos.html. The only problem is that adding the
<a data-lightbox ...>can't be done inline inside thediv.Collagebecause of the jQuery Collage plugin. It has to be done dynamically with a.wrap()call - which is ok, just not the most logical :P Take a look and tell me your thoughts...