-
Notifications
You must be signed in to change notification settings - Fork 59
fix(server): surface chat-template errors #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+711
−538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gufengc
reviewed
Nov 10, 2025
gufengc
reviewed
Nov 10, 2025
gufengc
reviewed
Nov 10, 2025
gufengc
approved these changes
Nov 10, 2025
Collaborator
Author
|
123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 PR Title
fix(server): surface chat-template errors
📝 Change Type
💡 Description
Malformed chat requests that embed
<|channel|>tags inmessages[*].contentcaused the executor’s tokenizer step to raise a template error, leaving the scheduler hanging and never responding to the client. This PR forwards those failures back through the IPC channel so the HTTP handler can immediately return a structured 400 error while keeping the node healthy. It also adds unit coverage for the new HTTP error-handling path.Key Changes
_notify_http_request_errorinExecutorto catch tokenizer/chat-template exceptions and send error envelopes to the HTTP server.HTTPHandlerto track per-request error state, stream error chunks, and emit non-streaming 400 responses.🔗 Related Issues