Skip to content

Conversation

@Odysseusailoon
Copy link
Collaborator

@Odysseusailoon Odysseusailoon commented Nov 10, 2025

📋 PR Title

fix(server): surface chat-template errors

📝 Change Type

  • fix: Bug fix.

💡 Description

Malformed chat requests that embed <|channel|> tags in messages[*].content caused the executor’s tokenizer step to raise a template error, leaving the scheduler hanging and never responding to the client. This PR forwards those failures back through the IPC channel so the HTTP handler can immediately return a structured 400 error while keeping the node healthy. It also adds unit coverage for the new HTTP error-handling path.

Key Changes

  1. Add _notify_http_request_error in Executor to catch tokenizer/chat-template exceptions and send error envelopes to the HTTP server.
  2. Extend HTTPHandler to track per-request error state, stream error chunks, and emit non-streaming 400 responses.
  3. Manually test it on the machine.
Screenshot 2025-11-09 at 5 56 06 PM

🔗 Related Issues

@Odysseusailoon Odysseusailoon requested a review from a team November 10, 2025 01:55
@Odysseusailoon
Copy link
Collaborator Author

123

@Odysseusailoon Odysseusailoon merged commit 489ddff into main Nov 14, 2025
3 checks passed
@Odysseusailoon Odysseusailoon deleted the asuka_bugfix branch November 14, 2025 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Failed requests cause the node to be unavailable

4 participants