This repository was archived by the owner on Sep 24, 2019. It is now read-only.
Add FilmRate Mutation #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuorig
commented
Feb 13, 2017
Collaborator
Author
There was a problem hiding this comment.
that was just for dev, we can remove once auth ships
Contributor
There was a problem hiding this comment.
Cool, we can change now :D
cjoudrey
reviewed
Feb 13, 2017
Contributor
There was a problem hiding this comment.
:filmRate.. or :rateFilm, but yeah maybe not movie.
xuorig
force-pushed
the
film-mutation
branch
from
aee8272 to
bbc7968
Compare
xuorig
commented
Feb 13, 2017
cjoudrey
reviewed
Feb 13, 2017
Contributor
There was a problem hiding this comment.
@xuorig any objections? Feels like this is a dev error. 🤔
Collaborator
Author
There was a problem hiding this comment.
hmm yeah, you're right. No real app would ask for an id as input i guess
cjoudrey
reviewed
Feb 13, 2017
app/models/graph/schema.rb
Outdated
Contributor
There was a problem hiding this comment.
If id is garbage, gid will be nil and will 💥 later.
xuorig
commented
Feb 13, 2017
cjoudrey
reviewed
Feb 13, 2017
app/models/rating.rb
Outdated
Contributor
There was a problem hiding this comment.
Better error message when you do this.
xuorig
commented
Feb 13, 2017
Collaborator
Author
There was a problem hiding this comment.
did you want to return rating too ? if you rebase you have a type
cjoudrey
force-pushed
the
film-mutation
branch
from
2f917bf to
3196c8d
Compare
Collaborator
Author
|
🚢 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cjoudrey