From ef94e6fe0bdf601c88757b6eb8c4059d815ae10f Mon Sep 17 00:00:00 2001 From: Daniel Stone Date: Tue, 14 Jul 2020 12:19:50 +0100 Subject: [PATCH 1/2] Fix switchMap import --- .../java/guide/graphql/toc/ui/chapters/ChaptersViewModel.kt | 2 -- .../java/guide/graphql/toc/ui/sections/SectionsViewModel.kt | 4 +--- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/app/src/main/java/guide/graphql/toc/ui/chapters/ChaptersViewModel.kt b/app/src/main/java/guide/graphql/toc/ui/chapters/ChaptersViewModel.kt index 8839ec6..cc80c6b 100644 --- a/app/src/main/java/guide/graphql/toc/ui/chapters/ChaptersViewModel.kt +++ b/app/src/main/java/guide/graphql/toc/ui/chapters/ChaptersViewModel.kt @@ -13,8 +13,6 @@ import guide.graphql.toc.apolloClient class ChaptersViewModel : ViewModel() { - val bookId: LiveData = MutableLiveData(0) - val chapterList: LiveData>> = liveData { emit(Resource.loading(null)) try { diff --git a/app/src/main/java/guide/graphql/toc/ui/sections/SectionsViewModel.kt b/app/src/main/java/guide/graphql/toc/ui/sections/SectionsViewModel.kt index d333882..e147660 100644 --- a/app/src/main/java/guide/graphql/toc/ui/sections/SectionsViewModel.kt +++ b/app/src/main/java/guide/graphql/toc/ui/sections/SectionsViewModel.kt @@ -1,9 +1,7 @@ package guide.graphql.toc.ui.sections import android.util.Log -import androidx.lifecycle.LiveData -import androidx.lifecycle.MutableLiveData -import androidx.lifecycle.ViewModel +import androidx.lifecycle.* import com.apollographql.apollo.coroutines.toDeferred import com.apollographql.apollo.exception.ApolloException import guide.graphql.toc.Resource From 76003a85e0330020cfae24930274a025aef0dca8 Mon Sep 17 00:00:00 2001 From: Daniel Stone Date: Tue, 14 Jul 2020 12:57:42 +0100 Subject: [PATCH 2/2] Fix fragment container view crash see https://issuetracker.google.com/issues/142847973 --- .../main/java/guide/graphql/toc/MainActivity.kt | 14 +++++++++++--- .../graphql/toc/ui/chapters/ChaptersViewModel.kt | 1 - app/src/main/res/layout/activity_main.xml | 2 +- 3 files changed, 12 insertions(+), 5 deletions(-) diff --git a/app/src/main/java/guide/graphql/toc/MainActivity.kt b/app/src/main/java/guide/graphql/toc/MainActivity.kt index 56b9e45..ac5f68e 100644 --- a/app/src/main/java/guide/graphql/toc/MainActivity.kt +++ b/app/src/main/java/guide/graphql/toc/MainActivity.kt @@ -2,29 +2,37 @@ package guide.graphql.toc import android.os.Bundle import androidx.appcompat.app.AppCompatActivity -import androidx.navigation.findNavController +import androidx.navigation.NavController +import androidx.navigation.fragment.NavHostFragment import androidx.navigation.ui.NavigationUI import guide.graphql.toc.databinding.ActivityMainBinding + class MainActivity : AppCompatActivity() { private lateinit var binding: ActivityMainBinding + private lateinit var navController: NavController override fun onCreate(savedInstanceState: Bundle?) { super.onCreate(savedInstanceState) binding = ActivityMainBinding.inflate(layoutInflater) + val navHostFragment = supportFragmentManager + .findFragmentById(R.id.nav_host_fragment) as NavHostFragment? + + navController = navHostFragment!!.navController + setContentView(binding.root) setSupportActionBar(binding.toolbar) NavigationUI.setupActionBarWithNavController( this, - findNavController(R.id.nav_host_fragment) + navController ) } override fun onSupportNavigateUp(): Boolean { - return findNavController(R.id.nav_host_fragment).navigateUp() || super.onSupportNavigateUp() + return navController.navigateUp() || super.onSupportNavigateUp() } } diff --git a/app/src/main/java/guide/graphql/toc/ui/chapters/ChaptersViewModel.kt b/app/src/main/java/guide/graphql/toc/ui/chapters/ChaptersViewModel.kt index cc80c6b..3aee80f 100644 --- a/app/src/main/java/guide/graphql/toc/ui/chapters/ChaptersViewModel.kt +++ b/app/src/main/java/guide/graphql/toc/ui/chapters/ChaptersViewModel.kt @@ -2,7 +2,6 @@ package guide.graphql.toc.ui.chapters import android.util.Log import androidx.lifecycle.LiveData -import androidx.lifecycle.MutableLiveData import androidx.lifecycle.ViewModel import androidx.lifecycle.liveData import com.apollographql.apollo.coroutines.toDeferred diff --git a/app/src/main/res/layout/activity_main.xml b/app/src/main/res/layout/activity_main.xml index 84173e6..3710a93 100644 --- a/app/src/main/res/layout/activity_main.xml +++ b/app/src/main/res/layout/activity_main.xml @@ -23,7 +23,7 @@ android:theme="@style/AppTheme.Toolbar" /> -