Modify blockstring support to be closer to canonical js implementation #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also add \””” support and a few more tests.
Contributor
Author
|
Did not rewrite I'd like to compare the output of the js version for block strings but I don't have a js setup and the js sandbox wouldn't let me access Lexer directly (not sure why). |
Contributor
Author
|
I also have an updated version of the description support PR that is similarly closer to the canonical js implementation but it requires this update to be merged first. |
Merged
naming is hard…
paulofaria
approved these changes
Aug 27, 2020
Member
paulofaria
left a comment
paulofaria
left a comment
There was a problem hiding this comment.
@haikusw Looks good to me, is it ready to merge?
Contributor
Author
Thank you. Yes, ready to merge. |
Member
|
Thank you! @haikusw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the blockstring support implementation to be closer to canonical js implementation, and also add \””” support as well as a few more tests.