Skip to content

Conversation

@cuva
Copy link
Contributor

@cuva cuva commented Apr 15, 2017

Previously providing a field of type [Int] would define a GraphQL type [Int!] instead of defining [Int!]!. In order to define a [Int!] GraphQL type, one should now provide [Int]?.

The following cases are now properly handled:

Swift Type GraphQL Type
[Int] [Int!]!
[Int?] [Int]!
[Int]? [Int!]
[Int?]? [Int]

Simplifies getGraphQLType(from:) to always recurse at least once given a wrapped type to avoid duplicate logic.

@codecov-io
Copy link

codecov-io commented Apr 15, 2017

Codecov Report

Merging #7 into master will increase coverage by 1.37%.
The diff coverage is 96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   81.31%   82.69%   +1.37%     
==========================================
  Files          13       13              
  Lines        1686     1745      +59     
==========================================
+ Hits         1371     1443      +72     
+ Misses        315      302      -13
Impacted Files Coverage Δ
...s/GraphitiTests/StarWarsTests/StarWarsSchema.swift 80% <ø> (ø) ⬆️
...sts/StarWarsTests/StarWarsIntrospectionTests.swift 97.55% <100%> (ø) ⬆️
Sources/Graphiti/Schema/Schema.swift 57.34% <94.73%> (+10.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9d909...57fe9f7. Read the comment docs.

@paulofaria paulofaria merged commit 4b50a6d into GraphQLSwift:master Apr 15, 2017
@paulofaria
Copy link
Member

thanks a lot (:

@paulofaria
Copy link
Member

merged and tagged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants