Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add built-in support for blacklisting domains via the local DNS resolver #184

Open
thestinger opened this issue Mar 2, 2020 · 5 comments
Open

Comments

@thestinger
Copy link
Member

@thestinger thestinger commented Mar 2, 2020

Domain-based filtering can be done without this by configuring a custom Private DNS server or a local DNS service provided by a VPN service app (does not require the app to intercept any traffic). However, it would be nice to support custom local blacklists.

This should be efficient, unlike a hosts file, i.e. it should actually use an existing cache or a new hash table.

Private DNS isn't compatible with domain-based apps, since the DNS traffic is passed through them encrypted. This means users are pushed to disable Private DNS by the apps, and they generally won't provide their own implementation of encrypted DNS.

@renlord
Copy link
Member

@renlord renlord commented Mar 10, 2020

Do you want a user-facing app to allow users to add/remove domains?

@thestinger
Copy link
Member Author

@thestinger thestinger commented Mar 10, 2020

It should probably be in the Settings app whether or not it's implemented as a separate app, similar to Updater.

@Kein
Copy link

@Kein Kein commented Aug 15, 2020

Could DNSCrypt service be used as a local resolver? It can even mimic DOH server for Private DNS and already has built-in extended blacklist support or cloaking.

@thestinger
Copy link
Member Author

@thestinger thestinger commented Aug 15, 2020

That doesn't make sense as a way of implementing this.

@thestinger
Copy link
Member Author

@thestinger thestinger commented Aug 15, 2020

It's not wanted. The existing DNS-over-TLS implementation is fine and we don't want to add and maintain a bunch of complexity for bikeshedding it, sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.