Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate connectivitycheck.grapheneos.org as an option for connectivity / captive portal checks - MUST preserve the option to mimic the standard checks to blend in #198

Open
thestinger opened this issue Apr 7, 2020 · 1 comment
Assignees

Comments

@thestinger
Copy link
Member

@thestinger thestinger commented Apr 7, 2020

There are already settings for this, so it just needs to be exposed in the Settings app as an option. To start, it would make sense to list "GrapheneOS" and "Standard" as the options. It would be fine to make "GrapheneOS" into the default once this is available as an option, and it's one more thing for people to change to hide that they're running GrapheneOS. These changes are already all documented in the default connections section so it's just one more thing for people to change which isn't too bad. The important thing is preserving the ability to use the standard URLs.

The trivial service is already implemented:

% curl -w '%{http_code}\n' http://connectivitycheck.grapheneos.org/generate_204 
204
% curl -w '%{http_code}\n' https://connectivitycheck.grapheneos.org/generate_204
204

As far I know, the checks in Vanadium (Chromium) are active too, so those probably need to be adjusted to respect the system setting. It would be less than ideal to have separate settings.

@thestinger thestinger changed the title integrate connectivitycheck.grapheneos.org as an option for connectivity / captive portal checks integrate connectivitycheck.grapheneos.org as an option for connectivity / captive portal checks - MUST be optional Apr 7, 2020
@thestinger thestinger changed the title integrate connectivitycheck.grapheneos.org as an option for connectivity / captive portal checks - MUST be optional integrate connectivitycheck.grapheneos.org as an option for connectivity / captive portal checks - MUST preserve the option to mimic the standard checks to blend in Apr 7, 2020
@thestinger
Copy link
Member Author

@thestinger thestinger commented Jun 22, 2020

There are 3 settings: http URL, https URL and fallback URL. For now, the http URL could probably be reused as the fallback URL, or we could make another DNS entry for it.

@thestinger thestinger closed this Jun 22, 2020
@thestinger thestinger reopened this Jun 22, 2020
@renlord renlord self-assigned this Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.