feat(client): add GAS.update_dataset for changing alias #813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1028803727
💛 - Coveralls |
rexzheng324-c
requested changes
Jul 12, 2021
rexzheng324-c
requested changes
Jul 12, 2021
AChenQ
approved these changes
Jul 12, 2021
linjiX
requested changes
Jul 12, 2021
edsn60
changed the title
linjiX
requested changes
Jul 13, 2021
| """ | ||
| dataset_id = self._get_dataset(name)["id"] | ||
| patch_data = {} |
There was a problem hiding this comment.
what if alias is ... and patch_data is {}
There was a problem hiding this comment.
The request will be sent only if patch_data is not empty.
edsn60
changed the title
linjiX
approved these changes
Jul 13, 2021
rexzheng324-c
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.