feat(opendataset): add masks for BDD100K_10K dataset #973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1192962262
💛 - Coveralls |
linjiX
requested changes
Aug 27, 2021
Lee-000
requested changes
Aug 27, 2021
graczhual
reviewed
Aug 27, 2021
marshallmallows
force-pushed
the
T17267_BDD100K_10K_mask_loader
branch
from
ff6f655 to
ceede23
Compare
linjiX
requested changes
Aug 31, 2021
marshallmallows
force-pushed
the
T17267_BDD100K_10K_mask_loader
branch
from
ceede23 to
4a12a9e
Compare
linjiX
requested changes
Aug 31, 2021
marshallmallows
force-pushed
the
T17267_BDD100K_10K_mask_loader
branch
from
4a12a9e to
12f1002
Compare
linjiX
requested changes
Aug 31, 2021
marshallmallows
force-pushed
the
T17267_BDD100K_10K_mask_loader
branch
3 times, most recently
from
954d586 to
bd5779b
Compare
linjiX
requested changes
Sep 1, 2021
linjiX
requested changes
Sep 1, 2021
|
|
||
|
|
||
| def _get_instance_mask(filename: str, original_mask_path: str, mask_directory: str) -> InstanceMask: | ||
| mask_path = os.path.join(mask_directory, f"{filename}.png") |
There was a problem hiding this comment.
can we use mask_filename rather than mask_path?
There was a problem hiding this comment.
this is actually a path, use mask_filename may be a little weird.
linjiX
requested changes
Sep 1, 2021
| all_attributes = {} | ||
| if seg_type == "pan": | ||
| all_category_ids = {} | ||
| for instance_info in set(map(tuple, np.reshape(mask, (-1, 4)))): |
There was a problem hiding this comment.
Is this map to tuple necessary?
There was a problem hiding this comment.
Use set to get all different pixels
np.ndarray is unhashable, so I must map the pixels to tuple
linjiX
requested changes
Sep 1, 2021
|
|
||
| def _generate_test_data(image_subdir: str, _: str, __: _DATA_GETTER) -> Iterable[Data]: | ||
| yield from map(Data, _utility.glob(os.path.join(image_subdir, "*.jpg"))) | ||
| yield from map(Data, glob(os.path.join(image_subdir, "*.jpg"))) |
There was a problem hiding this comment.
this function is called only once, also there is only one line, is it necessary to write a function?
There was a problem hiding this comment.
This function is used for reusing _load_tracking_segment for MOT and MOTS
Lee-000
requested changes
Sep 1, 2021
| all_attributes = {} | ||
| if seg_type == "pan": | ||
| all_category_ids = {} | ||
| for instance_info in set(map(tuple, np.reshape(mask, (-1, 4)))): |
There was a problem hiding this comment.
Is this map to tuple necessary?
marshallmallows
force-pushed
the
T17267_BDD100K_10K_mask_loader
branch
from
bd5779b to
a1bb11a
Compare
linjiX
approved these changes
Sep 1, 2021
Lee-000
approved these changes
Sep 1, 2021
marshallmallows
force-pushed
the
T17267_BDD100K_10K_mask_loader
branch
from
a1bb11a to
b1b35c4
Compare
marshallmallows
force-pushed
the
T17267_BDD100K_10K_mask_loader
branch
from
b1b35c4 to
4917ce9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.