Enhanced Media Library conflict with Gravity PDF #433

Closed
jakejackson1 opened this Issue Jul 6, 2016 · 3 comments

Projects

None yet

1 participant

@jakejackson1
Member

User reported the following error when trying to activate Gravity PDF on their Subdomain Multisite install:

Fatal error: Uncaught Error: Call to undefined function wp_terms_checklist() in /var/www/vhosts/marianilandscape.com/httpdocs/wp-content/plugins/enhanced-media-library/enhanced-media-library.php:396 Stack trace: #0 /var/www/vhosts/marianilandscape.com/httpdocs/wp-includes/plugin.php(525): wpuxss_eml_enqueue_media('') #1 /var/www/vhosts/marianilandscape.com/httpdocs/wp-includes/media.php(3503): do_action('wp_enqueue_medi...') #2 /var/www/vhosts/marianilandscape.com/httpdocs/wp-content/plugins/gravity-forms-pdf-extended/src/bootstrap.php(516): wp_enqueue_media() #3 /var/www/vhosts/marianilandscape.com/httpdocs/wp-includes/plugin.php(525): GFPDF\Router->load_assets('') #4 /var/www/vhosts/marianilandscape.com/httpdocs/wp-settings.php(393): do_action('init') #5 /var/www/vhosts/marianilandscape.com/httpdocs/wp-config.php(99): require_once('/var/www/vhosts...') #6 /var/www/vhosts/marianilandscape.com/httpdocs/wp-load.php(37): require_once('/var/www/vhosts...') #7 /var/www/vhosts/marianilandscape.com/httpdocs/wp-admin/admin.php(3 in /var/www/vhosts/marianilandscape.com/httpdocs/wp-content/plugins/enhanced-media-library/enhanced-media-library.php on line 396
@jakejackson1 jakejackson1 added the Bug label Jul 6, 2016
@jakejackson1
Member
jakejackson1 commented Jul 11, 2016 edited

Tried to replicate the issue but couldn't. Closing for now

@jakejackson1 jakejackson1 added Unconfirmed Bug and removed Bug labels Jul 11, 2016
@jakejackson1 jakejackson1 reopened this Aug 16, 2016
@jakejackson1 jakejackson1 added Bug and removed Unconfirmed Bug labels Aug 16, 2016
@jakejackson1 jakejackson1 added this to the 4.0.4 milestone Aug 16, 2016
@jakejackson1
Member

Was able to replicate this issue. Reopening to investigate further.

@jakejackson1 jakejackson1 pushed a commit that referenced this issue Aug 16, 2016
Jake Jackson Queue admin assests during admin_enqueue_scripts action
Resolves #433
f6b3e0f
@jakejackson1
Member

After reviewing, this issue stems from our enqueuing of scripts and styles too early (on the init action). To correct this we're changing to admin_enqueue_scripts which WordPress docs recommend: https://developer.wordpress.org/reference/hooks/admin_enqueue_scripts/

@jakejackson1 jakejackson1 pushed a commit that referenced this issue Aug 19, 2016
Jake Jackson Queue admin assests during admin_enqueue_scripts action
Resolves #433

Ensure unit test matches new changes to our bootstrap file
f516e38
@jakejackson1 jakejackson1 closed this in #476 Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment