PDF Tmp directory Test #519

Closed
jakejackson1 opened this Issue Nov 9, 2016 · 0 comments

Projects

None yet

1 participant

@jakejackson1
Member

To ensure our test is accurate we should read the actual content that is returned by our test file. If we do get the file's content we know the directory is accessible publicly.

@jakejackson1 jakejackson1 added the Bug label Nov 9, 2016
@jakejackson1 jakejackson1 modified the milestone: v4.1 Nov 19, 2016
@jakejackson1 jakejackson1 pushed a commit that referenced this issue Nov 19, 2016
Jake Jackson Add additional check to our PDF tmp directory test
Instead of blindly checking for a 200 status response we also read the body of the response and see if it matches what we saved to the file. This will prevent problems with any redirects in place, and should prevent all false positives.

Fixes #519
697a363
@jakejackson1 jakejackson1 closed this in #522 Nov 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment