Standardise all AJAX authentication to prevent repeat code #538

Merged
merged 1 commit into from Nov 23, 2016

Projects

None yet

1 participant

@jakejackson1
Member

We're now using Helper_Misc::handle_ajax_authentication for all AJAX authentication which checks user capabilities and does an Nonce check (prevents CORS).

We also adding missing unit tests for AJAX endpoints and fixed up an endpoint that didn't have an nonce.

Resolves #515

Jake Jackson Standardise all AJAX authentication to prevent repeat code
We're now using Helper_Misc::handle_ajax_authentication for all AJAX authentication which checks user capabilities and does an Nonce check (prevents CORS).

We also adding missing unit tests for AJAX endpoints and fixed up an endpoint that didn't have an nonce.

Resolves #515
d101fd9
@jakejackson1 jakejackson1 merged commit 8ebda3d into development Nov 23, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jakejackson1 jakejackson1 deleted the ajax-authentication branch Nov 23, 2016
@jakejackson1 jakejackson1 modified the milestone: v4.1 Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment