Fix issue with Advanced Template Manager opening in Safari #603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked this problem down to Safari's document.activeElement not pointing to the correct dom node when the button was clicked. IE also showed the template manager when enter is pressed on non-ReactJS managed compenents.
I discovered browsers will treat the first
<button>
tag as the submit if the type isn't explicitly set to "button". Once done, I could remove the activeElement checks and fix the problem.