Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with Advanced Template Manager opening in Safari #603

Merged
merged 1 commit into from Mar 28, 2017

Conversation

jakejackson1
Copy link
Member

@jakejackson1 jakejackson1 commented Mar 28, 2017

Tracked this problem down to Safari's document.activeElement not pointing to the correct dom node when the button was clicked. IE also showed the template manager when enter is pressed on non-ReactJS managed compenents.

I discovered browsers will treat the first <button> tag as the submit if the type isn't explicitly set to "button". Once done, I could remove the activeElement checks and fix the problem.

Tracked this problem down to Safari's document.activeElement not pointing to the correct dom node when the button was clicked. IE also showed the template manager when enter is pressed on non-ReactJS managed compenents.

I discovered browsers will treat the first <button> tag as the submit if the type isn't explicitly set to "button". Once done, I could remove the activeElement checks and fix the problem.
@jakejackson1 jakejackson1 added this to the 4.1.1 milestone Mar 28, 2017
@jakejackson1 jakejackson1 merged commit 216d57c into development Mar 28, 2017
@jakejackson1 jakejackson1 deleted the safari-bug branch March 28, 2017 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant