New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

en_US base localization #815

Merged
merged 1 commit into from Sep 12, 2018

Conversation

Projects
None yet
2 participants
@garrett-eclipse
Copy link
Contributor

garrett-eclipse commented Sep 11, 2018

Mostly string changes for en_US base localization, but also 2 spelling mistakes.

Garrett Hyder
@codecov

This comment has been minimized.

Copy link

codecov bot commented Sep 11, 2018

Codecov Report

Merging #815 into development will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #815   +/-   ##
============================================
  Coverage        62.61%   62.61%           
============================================
  Files              199      199           
  Lines            10445    10445           
  Branches           215      215           
============================================
  Hits              6540     6540           
  Misses            3905     3905
Impacted Files Coverage Δ
src/view/html/Welcome/welcome.php 12.24% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e153050...b836c23. Read the comment docs.

@jakejackson1

This comment has been minimized.

Copy link
Member

jakejackson1 commented Sep 12, 2018

Thanks for your contribution @garrett-eclipse. Everything looks in order.

@jakejackson1 jakejackson1 merged commit 66591a6 into GravityPDF:development Sep 12, 2018

3 checks passed

codecov/patch Coverage not affected when comparing e153050...b836c23
Details
codecov/project 62.61% remains the same compared to e153050
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@garrett-eclipse garrett-eclipse deleted the garrett-eclipse:enUS-localization branch Sep 12, 2018

@garrett-eclipse

This comment has been minimized.

Copy link
Contributor Author

garrett-eclipse commented Sep 12, 2018

Awesome, all the best

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment