New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race conditions in start/stop/restart code for the exec runner #123

Merged
merged 1 commit into from Jan 6, 2017

Conversation

Projects
None yet
2 participants
@bernd
Member

bernd commented Jan 5, 2017

This changes the Runner interface to only implement a Restart and Shutdown function. Using separate Start and Stop functions is prone to race conditions and would need complicated locking to avoid starting duplicate processes.

Fix race conditions in start/stop/restart code for the exec runner
This changes the Runner interface to only implement a Restart and Shutdown
function. Using separate Start and Stop functions is prone to race
conditions and would need complicated locking to avoid starting
duplicate processes.

@bernd bernd added this to the 2.2.0 milestone Jan 5, 2017

@bernd bernd requested a review from mariussturm Jan 5, 2017

@mariussturm

This comment has been minimized.

Member

mariussturm commented Jan 6, 2017

LGTM!

@mariussturm mariussturm merged commit abadd82 into issue-116 Jan 6, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

bernd added a commit that referenced this pull request Jan 6, 2017

Fix race conditions in start/stop/restart code for the exec runner (#123
)

This changes the Runner interface to only implement a Restart and Shutdown
function. Using separate Start and Stop functions is prone to race
conditions and would need complicated locking to avoid starting
duplicate processes.

@mariussturm mariussturm deleted the issue-116-fix-races branch Jan 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment