Skip to content

Add a composer.json file to support Composer (http://getcomposer.org/). #9

Merged
merged 1 commit into from Apr 26, 2012

3 participants

@msabramo
msabramo commented Apr 5, 2012

This adds a composer.json file that describes gelf-php and will allow people to install it with Composer by referring to the GitHub repo in their composer.json (see http://getcomposer.org/doc/05-repositories.md#vcs for details on how this would work).

A nice follow-up to this would be to publish gelf-php on packagist; then people will be able to install it even more easily without having to add a custom repo to their composer.json.

See my gelf-php-test repo, which illustrates how to use a composer.json to import my fork of gelf-php into a project.

@Seldaek
Seldaek commented Apr 6, 2012

I would recommend using a classmap autoloader, with just [""] as config, so it scans all files for classes. That way the namespace pull request becomes optional, which is probably better since it means requiring php 5.3, it may not be well received.

@msabramo
msabramo commented Apr 6, 2012

@Seldaek Are you saying to have both a classmap autoloader AND a PSR-0 autoloader or to switch to just a classmap autoloader? I have an example of the former approach in 578d19b.

@Seldaek
Seldaek commented Apr 8, 2012

I mean just the classmap one. Having both serves no purpose really.

@lennartkoopmann lennartkoopmann merged commit f0e2636 into Graylog2:master Apr 26, 2012
@lennartkoopmann
Graylog member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.