Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow injecting a sender. #28

Closed

Conversation

craigw
Copy link

@craigw craigw commented Feb 16, 2015

This is useful for adding e.g. a TCP sender which may not necessarily be packaged in gelf-rb.

Note that passing in your own sender does make the host and port a little pointless. This may be something to address in a future refactoring?

This is useful for adding e.g. a TCP sender which may not necessarily be
packaged in gelf-rb.

Note that passing in yur own sender does make the host and port a little
pointless. This may be something to address in a future refactoring?
@joschi joschi added the needs-ca label May 6, 2015
@joschi
Copy link
Contributor

joschi commented May 6, 2015

Thanks for contributing to this project! To continue merging this PR, we need you to sign our Individual Contributor Assignment Agreement as described in https://www.graylog.org/contributing-to-graylog/

@milgner
Copy link
Contributor

milgner commented Aug 21, 2016

In the latest version of the gem, initialisation of the transport/sender is done in GELF::Notifier#create_sender. For those rare cases that require a custom implementation, wouldn't it be easier to subclass and override that method?

@craigw craigw closed this Aug 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants