New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy configuration to AWSPluginConfiguration component #61

Merged
merged 1 commit into from Jan 18, 2018

Conversation

Projects
None yet
3 participants
@joschi
Contributor

joschi commented Jan 17, 2018

The HTTP Proxy setting was "lost" in 0939ef1.

Fixes #59

@joschi joschi added this to the 3.0.0 milestone Jan 17, 2018

Add proxy configuration to AWSPluginConfiguration component
The HTTP Proxy setting was "lost" in 0939ef1.

Fixes #59

@joschi joschi force-pushed the issue-59 branch from 32b44ca to 1d98348 Jan 17, 2018

@lennartkoopmann lennartkoopmann modified the milestones: 3.0.0, 2.4.1 Jan 17, 2018

@lennartkoopmann

This comment has been minimized.

Member

lennartkoopmann commented Jan 17, 2018

This is definitely for a 2.4.1 release. I changed the milestone. @dennisoelkers can you review ASAP so we can get 2.4.1 out quick?

@lennartkoopmann lennartkoopmann requested a review from dennisoelkers Jan 17, 2018

@joschi

This comment has been minimized.

Contributor

joschi commented Jan 17, 2018

@lennartkoopmann This PR is for master, i. e. Graylog 3.0.0.

@lennartkoopmann

This comment has been minimized.

Member

lennartkoopmann commented Jan 17, 2018

Then we should definitely backport it. This is broken in 2.4.0 from what I can see.

@joschi

This comment has been minimized.

Contributor

joschi commented Jan 17, 2018

@lennartkoopmann Our workflow typically is:

  1. Fix in master
  2. Backport to other version branches
@lennartkoopmann

This comment has been minimized.

Member

lennartkoopmann commented Jan 17, 2018

Yepp, let's do that!

@dennisoelkers dennisoelkers merged commit 02874b0 into master Jan 18, 2018

2 checks passed

graylog-project/pr Jenkins build graylog-project-pr-snapshot 906 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@dennisoelkers dennisoelkers deleted the issue-59 branch Jan 18, 2018

joschi added a commit that referenced this pull request Jan 18, 2018

Merge pull request #61 from Graylog2/issue-59
Add proxy configuration to AWSPluginConfiguration component

(cherry picked from commit 02874b0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment