Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frame decoding in case of lost connection #17

Merged
merged 1 commit into from Oct 26, 2016
Merged

Conversation

@hc4
Copy link
Contributor

@hc4 hc4 commented Oct 26, 2016

Fixes #14 and #15
Removed readable bytes checks (it will be checked by ReplayingDecoder)
Added decodingLast implementation, that ignores all received data (we can't use it, because can't send ACK) and resets decoding state
Fixed error message for bad protocol version

Fixes #14 and #15
Removed readable bytes checks (it will be checked by ReplayingDecoder)
Added decodingLast implementation, that ignores all received data (we can't use it, because can't send ACK) and resets decoding state
Fixed error message for bad protocol version
@joschi joschi self-assigned this Oct 26, 2016
@joschi joschi added this to the 2.2.0 milestone Oct 26, 2016
@joschi
joschi approved these changes Oct 26, 2016
Copy link
Contributor

@joschi joschi left a comment

@hc4 LGTM. Thank you very much!

@joschi joschi merged commit 8c751e0 into Graylog2:master Oct 26, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
joschi pushed a commit that referenced this pull request Oct 26, 2016
Fixes #14
Fixes #15
(cherry picked from commit 8c751e0)
joschi pushed a commit that referenced this pull request Oct 26, 2016
Fixes #14
Fixes #15
(cherry picked from commit 8c751e0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants