New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not validate the lastSeen property as being in the past #3

Merged
merged 1 commit into from Apr 1, 2016

Conversation

Projects
None yet
2 participants
@kroepke
Member

kroepke commented Mar 31, 2016

this breaks due to a race condition creating the timestamp and validating the field. if both happens within the same millisecond it's not "past"

fix Graylog2/graylog2-server#2002
fix graylog-labs/graylog2-web-interface#1726

do not validate the lastSeen property as being in the past
this breaks due to a race condition creating the timestamp and validating the field. if both happens within the same millisecond it's not "past"

fix #2002
fix graylog-labs/graylog2-web-interface#1726
@bernd

This comment has been minimized.

Member

bernd commented Apr 1, 2016

LGTM 👍 (failing tests are due to missing dependencies, fixed in master)

@bernd bernd merged commit 72a18d1 into master Apr 1, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@bernd bernd deleted the issue-2002 branch Apr 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment