New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of Period instances #58

Merged
merged 1 commit into from Jun 6, 2017

Conversation

Projects
None yet
2 participants
@bernd
Member

bernd commented Jun 6, 2017

To get the seconds value of a period, it first has to be converted to a Duration. Otherwise the wrong value (0) will be used when the Period is not "PTnS" but "PTnH", for example.

Change updateInterval in CollectorRegistrationConfiguration from int to long to avoid a type cast.

Fixes #57

Fix usage of Period instances
To get the seconds value of a period, it first has to be converted to a
Duration. Otherwise the wrong value (0) will be used when the Period is not
"PTnS" but "PTnH", for example.

Change updateInterval in CollectorRegistrationConfiguration from int to
long to avoid a type cast.

Fixes #57

@bernd bernd added this to the 2.3.0 milestone Jun 6, 2017

@bernd bernd requested a review from mariussturm Jun 6, 2017

@mariussturm

This comment has been minimized.

Member

mariussturm commented Jun 6, 2017

LGTM! 👍

@mariussturm mariussturm merged commit a69feef into master Jun 6, 2017

2 of 3 checks passed

graylog-project/pr Jenkins build graylog-project-pr-snapshot 165 is running
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mariussturm mariussturm deleted the issue-57 branch Jun 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment