4.3 Backport: Handle Teams Notification fields with colon characters #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor MS Teams and Slack message objects to use AutoValue
ryan-carroll-graylog
approved these changes
Oct 20, 2022
| webhookUrl, | ||
| message.getJsonString()); | ||
| ""); |
There was a problem hiding this comment.
Did you want to add the message here:
Suggested change
| ""); | |
| objectMapper.writeValueAsString(message)); |
There was a problem hiding this comment.
Yep! Good catch!
kingzacko1
deleted the
backport-4.3/fix-msteams-notification-timestamp-issue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of non-breaking portion of #1202. This change leaves the Teams notification template parsing in tact but will correctly display values containing colons in key-value pairs. This will NOT address broken backlog messages that contain colons when templated by the default Teams notification template. That issue is fully addressed in the previously mentioned PR as part of breaking changes to existing Teams notifications.
Related to #1096 and #1200