Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Palo Alto Input parser does not properly capture quoted values #15

Closed
waynekearns opened this issue Apr 5, 2019 · 6 comments

Comments

Projects
None yet
2 participants
@waynekearns
Copy link

commented Apr 5, 2019

Description

Palo Alto logs are comma separated with optional double quotes for values that may include a comma. In the case of a quoted value, the Palo Alto Input breaks and counts the comma within the quotes and shifts the fields.

Steps To Reproduce

1.Forward Palo Alto logs to Palo Alto TCP Input for a Firewall with ThreatDetect enabled.
2. Send a log containing a comma in any field.
3. Observe as the fields shift.

A packet capture containing the offending messages are included.

palo.pcap.gz

Environment

  • Graylog Version: 3.0
  • Elasticsearch Version: 6.6
  • MongoDB Version: 4.0.2
  • Browser Version: All (tested 4 different browsers)

@waynekearns waynekearns added the bug label Apr 5, 2019

@danotorrey danotorrey self-assigned this Apr 5, 2019

@danotorrey

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

I am investigating this issue now. Also planning to provide a fix and snapshot build as soon as possible.

@danotorrey

This comment has been minimized.

Copy link
Contributor

commented Apr 5, 2019

This has been fixed with #16. A 3.0 snapshot build jar has been provided to @waynekearns. Thanks for testing @waynekearns!

Please see #16 for details on the fix.

@danotorrey

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

@waynekearns mentioned that additional unhandled cases were found. Details will be provided shortly. I'll continue investigating then.

@waynekearns

This comment has been minimized.

Copy link
Author

commented Apr 9, 2019

I don't yet have a PCAP.

Palo_alto_Broken_messages-20190408.txt

@danotorrey

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

Thank you @waynekearns! I will take a look and continue to investigate.

Can you tell me anything more about the specific issue/s that are happening now? (eg. malformed parsing, parsing errors)?

@danotorrey

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

My testing with the latest PCAP shows that this issue is resolved with the latest snapshot build. There might have been an issue with the previous jar. @waynekearns is planning to test a new snapshot build at the customer site to test confirm (probably tomorrow).

@danotorrey danotorrey removed the in progress label Apr 10, 2019

@bernd bernd closed this in #16 Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.