Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Palo Alto input parsing issue #11

Merged
merged 5 commits into from Mar 11, 2019

Conversation

Projects
None yet
3 participants
@danotorrey
Copy link
Contributor

commented Feb 25, 2019

Fixes issue #10.

@danotorrey danotorrey requested a review from bernd Feb 26, 2019

@danotorrey danotorrey added the backport label Feb 26, 2019

@danotorrey

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2019

@bernd @deeshe I think we should include this fix in 3.0.1. This means that a backport is required, correct? I also don't think it's necessary to backport to 2.5. Please let me know what you think.

Also, did I apply the labels/milestone/project correctly?

@danotorrey danotorrey added this to the 3.0.1 milestone Feb 26, 2019

@danotorrey danotorrey removed the backport label Feb 26, 2019

@danotorrey danotorrey added the backport label Feb 26, 2019

@deeshe

This comment has been minimized.

Copy link

commented Feb 27, 2019

@danotorrey The fix should definitely be included in 3.0.1 as @kroepke said.
The project and labels are perfect, thank you! 👍

@danotorrey

This comment has been minimized.

Copy link
Contributor Author

commented Mar 1, 2019

This change will be included in 3.0.1 and backported to 2.5.

@bernd

bernd approved these changes Mar 11, 2019

@bernd bernd merged commit d99cdc2 into master Mar 11, 2019

2 checks passed

graylog-project/pr Jenkins build graylog-project-pr-snapshot 3195 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@bernd bernd deleted the palo-alto-issue-10 branch Mar 11, 2019

bernd added a commit that referenced this pull request Mar 11, 2019

Fix Palo Alto input parsing issue (#11)
* Use Syslog TCP transport to correctly handle frame length
* Fully migrate to Syslog TCP Transport
* Trim line breaks from the message before parsing
* Add tests
* Roll back log message

Fixes #10

(cherry picked from commit d99cdc2)

bernd added a commit that referenced this pull request Mar 15, 2019

Fix Palo Alto input parsing issue (#11)
* Use Syslog TCP transport to correctly handle frame length
* Fully migrate to Syslog TCP Transport
* Trim line breaks from the message before parsing
* Add tests
* Roll back log message

(cherry picked from commit d99cdc2)

danotorrey added a commit that referenced this pull request Mar 21, 2019

Merge pull request #13 from Graylog2/pr-11-3.0
Fix Palo Alto input parsing issue (#11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.