Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore internal message fields (starting with "gl2_") #17

Merged
merged 2 commits into from Sep 6, 2016
Merged

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Sep 6, 2016

Closes #12

@edmundoa edmundoa self-assigned this Sep 6, 2016
@@ -131,6 +132,7 @@ public void filterResolvesIpGeoLocation() throws Exception {
assertEquals(metricRegistry.timer(name(GeoIpResolverEngine.class, "resolveTime")).getCount(), 3, "Should have looked up three IPs");
assertNull(message.getField("source_geolocation"), "Should not have resolved private IP");
assertNull(message.getField("message_geolocation"), "Should have resolved public IP inside message");
assertNull(message.getField("gl2_remote_ip_geolocation"), "Should have resolved internal message field");

This comment has been minimized.

@edmundoa

edmundoa Sep 6, 2016
Member

Nit-picking™: Shouldn't the message state the opposite? I think we want to display Should not have resolved internal message field in case gl2_remote_ip is not null.

This comment has been minimized.

@joschi

joschi Sep 6, 2016
Author Contributor

Haha, you're right. Not to forget the "not", not?

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Sep 6, 2016

Other than the minor nit-picking, looks good to me 👍

@edmundoa edmundoa merged commit 37ec37d into master Sep 6, 2016
@edmundoa edmundoa deleted the issue-12 branch Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants