Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify action components of all field analyzers #56

Merged
merged 1 commit into from Oct 10, 2017

Conversation

@lennartkoopmann
Copy link
Member

@lennartkoopmann lennartkoopmann commented Oct 7, 2017

This commit is a part of Graylog2/graylog2-server#4219, where the other field analyzer widgets were addressed.

This commit is a part of Graylog2/graylog2-server#4219, where the other field analyzer widgets were adressed.

This change unifies the action components (buttons and dropdowns) of all field analyzer widgets we ship. Those components are found in the top right corner of each widget.

* The "Dismiss Widget" button is now always a close icon and on the far right of all actions. Before it was sometimes directly accessible and sometimes hidden behind a "Customize" drop-down. The change to a close _icon_ makes it stand out more and also saves real-estate. A margin to the left helps identifying it quickly and avoids accidental pressing of it.
* The "Add to dashboard" button has the same and less intrusive button across all widgets now.
* The new Quick Values configuration dialog is accessible directly without going through the "Customize" drop-down. In fact, the "Customize" drop-down only had "Customize" as a menu item after "Dismiss" was moved to the new close widget icon.
@joschi
joschi approved these changes Oct 10, 2017
@joschi joschi merged commit 79c3b67 into master Oct 10, 2017
2 checks passed
2 checks passed
@garybot2
graylog-project/pr Jenkins build graylog-project-pr-snapshot 579 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@joschi joschi deleted the unify-field-analyzer-actions branch Oct 10, 2017
@ghost ghost removed the ready-for-review label Oct 10, 2017
@joschi joschi modified the milestones: 2.4.0, 3.0.0 Oct 10, 2017
joschi pushed a commit that referenced this pull request Oct 10, 2017
This commit is a part of Graylog2/graylog2-server#4219, where the other field analyzer widgets were adressed.

This change unifies the action components (buttons and dropdowns) of all field analyzer widgets we ship. Those components are found in the top right corner of each widget.

* The "Dismiss Widget" button is now always a close icon and on the far right of all actions. Before it was sometimes directly accessible and sometimes hidden behind a "Customize" drop-down. The change to a close _icon_ makes it stand out more and also saves real-estate. A margin to the left helps identifying it quickly and avoids accidental pressing of it.
* The "Add to dashboard" button has the same and less intrusive button across all widgets now.
* The new Quick Values configuration dialog is accessible directly without going through the "Customize" drop-down. In fact, the "Customize" drop-down only had "Customize" as a menu item after "Dismiss" was moved to the new close widget icon.

(cherry picked from commit 79c3b67)
@joschi joschi self-assigned this Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants