New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeZone arg get capsed in parse_date call #100

Closed
hc4 opened this Issue Sep 7, 2016 · 5 comments

Comments

Projects
None yet
4 participants
@hc4

hc4 commented Sep 7, 2016

Problem description

image

It was OK before update.

Environment

  • Graylog Version: 2.1.0 (62db7e0)
  • Pipeline Processor plugin version: 1.1.0
@hc4

This comment has been minimized.

hc4 commented Sep 7, 2016

Actualy I can't configure correct timezone now.
Where can I get list of all timezones?

UTC+3 not working
GMT+3 not working
Etc/GMT+3 not working

I'm lost :)

@hc4

This comment has been minimized.

hc4 commented Sep 7, 2016

Found solution.
Set timezone to "+03"

@edmundoa edmundoa added this to the 1.1.1 milestone Sep 12, 2016

@edmundoa edmundoa self-assigned this Sep 12, 2016

@edmundoa edmundoa added the bug label Sep 12, 2016

@kroepke

This comment has been minimized.

Member

kroepke commented Sep 12, 2016

The issue is that we chose to uppercase the timezone because the parser requires exact matches for "UTC", e.g.
I guess we need a lookup table for the zones :/

@edmundoa edmundoa assigned kroepke and unassigned edmundoa Sep 12, 2016

@joschi

This comment has been minimized.

Contributor

joschi commented Sep 12, 2016

@kroepke I don't get the reason for using the upper case version of the timezone. Could you please elaborate on that?

kroepke added a commit that referenced this issue Sep 12, 2016

use case insensitive lookup for timezone IDs
simply upper-casing timezone IDs failed for strings like 'Europe/Moscow'. Unfortunately the forID function is case sensitive.

fixes #100
@kroepke

This comment has been minimized.

Member

kroepke commented Sep 12, 2016

@joschi people were trying utc and expected that to work. That lead me to the mistake of simply uppercasing the timezone ID, but I forgot about the geographic names.
I've replaced it with a static lookup map now and added tests (see PR)

edmundoa added a commit that referenced this issue Sep 13, 2016

use case insensitive lookup for timezone IDs (#102)
* use case insensitive lookup for timezone IDs

simply upper-casing timezone IDs failed for strings like 'Europe/Moscow'. Unfortunately the forID function is case sensitive.

fixes #100

* override the millis provider to stabilize test

* remove unused statement and fix import

edmundoa added a commit that referenced this issue Sep 13, 2016

use case insensitive lookup for timezone IDs (#102)
* use case insensitive lookup for timezone IDs

simply upper-casing timezone IDs failed for strings like 'Europe/Moscow'. Unfortunately the forID function is case sensitive.

fixes #100

* override the millis provider to stabilize test

* remove unused statement and fix import

(cherry picked from commit fcd9e89)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment