Skip to content

/ graylog-plugin-pipeline-processor

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

select_jsonpath fails on missing json keys #232

Closed
kroepke opened this issue Dec 7, 2017 · 0 comments
Closed

select_jsonpath fails on missing json keys #232

kroepke opened this issue Dec 7, 2017 · 0 comments
Assignees
@kroepke
Labels
bug
Milestone
2.4.0

Comments

@kroepke
Copy link
Member

@kroepke kroepke commented Dec 7, 2017

When using select_jsonpath to extract one or more values from a JSON object, the function does not handle missing values gracefully and will fail the entire rule.

The test introduced in #209 unfortunately looks like it tests for the correct behavior, but the test harness is not exactly the same as the production code.

Thus we need to filter out null values in the function itself. The NPE is an unfortunate sideeffect of the Java streams map collector, rather than the overall "null-ness" of a value in a map.
@kroepke kroepke added the bug label Dec 7, 2017
@kroepke kroepke added this to the 2.4.0 milestone Dec 7, 2017
@kroepke kroepke self-assigned this Dec 7, 2017
kroepke added a commit that referenced this issue Dec 7, 2017
@kroepke
filter out null values when iterating over select_jsonpath results
Loading status checks…
6cf8efa 
fix #232
@kroepke kroepke mentioned this issue Dec 7, 2017
Merged
@ghost ghost added the in progress label Dec 7, 2017
@joschi joschi closed this in #233 Dec 7, 2017
joschi added a commit that referenced this issue Dec 7, 2017
@kroepke @joschi
Filter null values when iterating over `select_jsonpath` results (#233)
Loading status checks…
ecc33b8 
Fixes #232
@ghost ghost removed the in progress label Dec 7, 2017
joschi pushed a commit that referenced this issue Dec 7, 2017
@kroepke Jochen Schalanda
Filter null values when iterating over `select_jsonpath` results (#233)
Unverified
No user is associated with the committer email.
Learn about signing commits
Loading status checks…
dc0f0ea 
Fixes #232

(cherry picked from commit ecc33b8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kroepke kroepke

Labels
bug
Projects
None yet
Milestone
2.4.0
Linked pull requests

Successfully merging a pull request may close this issue.

filter out null values when iterating over select_jsonpath results
1 participant
@kroepke