Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upselect_jsonpath fails on missing json keys #232
Comments
kroepke
added
the
bug
label
Dec 7, 2017
kroepke
added this to the 2.4.0 milestone
Dec 7, 2017
kroepke
self-assigned this
Dec 7, 2017
added a commit
that referenced
this issue
Dec 7, 2017
kroepke
referenced this issue
Dec 7, 2017
Merged
filter out null values when iterating over select_jsonpath results #233
wafflebot
bot
added
the
in progress
label
Dec 7, 2017
joschi
closed this
in
#233
Dec 7, 2017
added a commit
that referenced
this issue
Dec 7, 2017
wafflebot
bot
removed
the
in progress
label
Dec 7, 2017
added a commit
that referenced
this issue
Dec 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
kroepke commentedDec 7, 2017
When using
select_jsonpathto extract one or more values from a JSON object, the function does not handle missing values gracefully and will fail the entire rule.The test introduced in #209 unfortunately looks like it tests for the correct behavior, but the test harness is not exactly the same as the production code.
Thus we need to filter out null values in the function itself. The NPE is an unfortunate sideeffect of the Java streams map collector, rather than the overall "null-ness" of a value in a map.