Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use case insensitive lookup for timezone IDs #102

Merged
merged 3 commits into from Sep 13, 2016
Merged

use case insensitive lookup for timezone IDs #102

merged 3 commits into from Sep 13, 2016

Conversation

@kroepke
Copy link
Member

@kroepke kroepke commented Sep 12, 2016

simply upper-casing timezone IDs failed for strings like 'Europe/Moscow'. Unfortunately the forID function is case sensitive.

fixes #100

simply upper-casing timezone IDs failed for strings like 'Europe/Moscow'. Unfortunately the forID function is case sensitive.

fixes #100
@kroepke kroepke added this to the 2.0 milestone Sep 12, 2016
@edmundoa edmundoa self-assigned this Sep 12, 2016
private final ParameterDescriptor<String, DateTimeZone> timeZoneParam;

public TimezoneAwareFunction() {
protected TimezoneAwareFunction() {
DateTimeZone.getAvailableIDs();

This comment has been minimized.

@edmundoa

edmundoa Sep 13, 2016
Member

This look like is not needed, can we remove it?

This comment has been minimized.

@kroepke

kroepke Sep 13, 2016
Author Member

urgs, left over!

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Sep 13, 2016

Other than that small remark, the change looks good to me 👍

@edmundoa edmundoa merged commit fcd9e89 into master Sep 13, 2016
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@edmundoa edmundoa deleted the issue-100 branch Sep 13, 2016
edmundoa added a commit that referenced this pull request Sep 13, 2016
* use case insensitive lookup for timezone IDs

simply upper-casing timezone IDs failed for strings like 'Europe/Moscow'. Unfortunately the forID function is case sensitive.

fixes #100

* override the millis provider to stabilize test

* remove unused statement and fix import

(cherry picked from commit fcd9e89)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.