New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not use lambdas with gauge metrics #152

Merged
merged 1 commit into from Jan 3, 2017

Conversation

Projects
None yet
2 participants
@kroepke
Member

kroepke commented Jan 3, 2017

instead use CacheStatsSet to expose guava cache stats to metric registry

Using lambdas screws up the metric type detection code, and subsequently the metric browser does not know how to render the resulting values.

fixes #146

do not use lambdas with gauge metrics
instead use CacheStatsSet to expose guava cache stats to metric registry

fixes #146

@kroepke kroepke added this to the 2.2.0 milestone Jan 3, 2017

@joschi

joschi approved these changes Jan 3, 2017

@joschi joschi self-assigned this Jan 3, 2017

@joschi joschi merged commit ff9ec56 into master Jan 3, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@joschi joschi deleted the issue-146 branch Jan 3, 2017

@joschi joschi removed the ready-for-review label Jan 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment