Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uppercase timezone in TimezoneAwareFunction and fix default value #169

Merged
merged 1 commit into from Mar 30, 2017

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Mar 28, 2017

This PR makes sure that the user-provided timezone in TimezoneAwareFunction is being looked up in uppercase and that the default timezone is "UTC".
Otherwise the timezone might not be found in the lookup table and the timezone parameter would be interpreted as the local system's timezone.

Fixes #168

@joschi joschi added this to the 2.3.0 milestone Mar 28, 2017
@joschi joschi added the bug label Mar 28, 2017
@joschi joschi requested a review from kroepke Mar 28, 2017
Copy link
Member

@kroepke kroepke left a comment

lgtm! Thanks!

@kroepke kroepke merged commit b3cbc50 into master Mar 30, 2017
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
@kroepke kroepke deleted the issue-168 branch Mar 30, 2017
joschi added a commit that referenced this pull request Mar 30, 2017
kroepke added a commit that referenced this pull request Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants