New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve lookup functions #191

Merged
merged 1 commit into from Jun 22, 2017

Conversation

Projects
None yet
2 participants
@bernd
Member

bernd commented Jun 21, 2017

  • Enable default parameter
  • Add a description for function parameters
  • Return null instead of an optional if the default is not set

This depends on Graylog2/graylog2-server#3921 to work correctly.

Improve lookup functions
- Enable default parameter
- Add a description for function parameters
- Return null instead of an optional if the default is not set

@bernd bernd added this to the 2.3.0 milestone Jun 21, 2017

@bernd bernd requested a review from kroepke Jun 21, 2017

@kroepke kroepke merged commit 8f4741a into master Jun 22, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 254 has succeeded
Details

@kroepke kroepke deleted the improve-lookup-functions branch Jun 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment