Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use friendlier error message in case of invalid expressions #196

Merged
merged 1 commit into from Jul 5, 2017
Merged

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Jul 5, 2017

Instead of throwing a NullPointerException for invalid unary expression where the constructor parameter right is null and for which the call to UnaryExpression#getType() will subsequently fail, the constructor now explicitly throws a ParseException with a SyntaxError (fail fast).

Closes #185

@joschi joschi added this to the 2.3.0 milestone Jul 5, 2017
@joschi joschi requested a review from kroepke Jul 5, 2017
@bernd bernd self-assigned this Jul 5, 2017
@bernd
bernd approved these changes Jul 5, 2017
Copy link
Member

@bernd bernd left a comment

Nice! LGTM 👍

@bernd bernd merged commit 7038153 into master Jul 5, 2017
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@garybot2
graylog-project/pr Jenkins build graylog-project-pr-snapshot 308 has succeeded
Details
@bernd bernd deleted the issue-185 branch Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants