New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort alphabetically by title in MongoDbRuleService#loadAll() #208

Merged
merged 1 commit into from Sep 11, 2017

Conversation

Projects
None yet
2 participants
@joschi
Contributor

joschi commented Aug 28, 2017

The previous implementation returned an intransparent sorting of rules to the user. Users expect a stable sorting of rules, so we'll sort them alphabetically by title to get a stable sorting.

Sort alphabetically by title in MongoDbRuleService#loadAll()
The previous implementation returned an intransparent sorting of rules
to the user. Users expect a stable sorting of rules, so we'll sort them
alphabetically by title to get a stable sorting.

@joschi joschi added this to the 2.4.0 milestone Aug 28, 2017

@bernd

bernd approved these changes Sep 11, 2017

LGTM 👍

@bernd bernd self-assigned this Sep 11, 2017

@bernd bernd merged commit cb2a320 into master Sep 11, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 413 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@bernd bernd deleted the sort-rules branch Sep 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment