Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse_json() returns MissingNode if input wasn't valid JSON #210

Merged
merged 1 commit into from Sep 11, 2017
Merged

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Sep 6, 2017

The parse_json() function is supposed to return a JsonNode but returned null if the input wasn't valid JSON.

This change set changes the return type to MissingNode if the input wasn't valid and couldn't be parsed.

Closes #209

Jochen Schalanda
The `parse_json()` function is supposed to return a `JsonNode` but returned
`null` if the input wasn't valid JSON.

This change set changes the return type to `MissingNode` if the input wasn't
valid and couldn't be parsed.

Closes #209
@joschi joschi added this to the 2.4.0 milestone Sep 6, 2017
@bernd bernd self-assigned this Sep 11, 2017
@bernd
bernd approved these changes Sep 11, 2017
Copy link
Member

@bernd bernd left a comment

LGTM 👍

@bernd bernd merged commit 3eba113 into master Sep 11, 2017
4 checks passed
4 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 421 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@bernd bernd deleted the issue-209 branch Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.