New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify type of 'value' (single or multi) for lookup functions. #217

Merged
merged 2 commits into from Oct 15, 2017

Conversation

Projects
None yet
2 participants
@supahgreg
Contributor

supahgreg commented Oct 14, 2017

This is intended to make lookup and lookup_value descriptions a bit more consistent with the Lookup Tables page and documentation.

@joschi

@supahgreg Thanks for your contribution!

I've got 2 minor nitpicks and then we're fine to merge this PR. 😃

@@ -62,7 +62,7 @@ public Lookup(LookupTableService lookupTableService) {
//noinspection unchecked
return FunctionDescriptor.<Map<Object, Object>>builder()
.name(NAME)
.description("Looks a value up in the named lookup table.")
.description("Looks a multi value up in the named lookup table.")

This comment has been minimized.

@joschi

joschi Oct 15, 2017

Contributor

This should probably read:

Looks up a multi value in the named lookup table.

@@ -57,7 +57,7 @@ public Object evaluate(FunctionArgs args, EvaluationContext context) {
//noinspection unchecked
return FunctionDescriptor.builder()
.name(NAME)
.description("Looks a value up in the named lookup table.")
.description("Looks a single value up in the named lookup table.")

This comment has been minimized.

@joschi

joschi Oct 15, 2017

Contributor

See above.

Looks up a single value in the named lookup table.

@joschi joschi self-assigned this Oct 15, 2017

@joschi joschi added the enhancement label Oct 15, 2017

@joschi joschi added this to the 3.0.0 milestone Oct 15, 2017

@supahgreg

This comment has been minimized.

Contributor

supahgreg commented Oct 15, 2017

@joschi Updated!

@joschi

joschi approved these changes Oct 15, 2017

@joschi

This comment has been minimized.

Contributor

joschi commented Oct 15, 2017

@supahgreg Thanks!

@joschi joschi merged commit 1f41130 into Graylog2:master Oct 15, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
graylog-project/pr Jenkins build graylog-project-pr-snapshot 601 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details

joschi added a commit that referenced this pull request Oct 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment