Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numeric conversions with to_double()/to_long() #219

Merged
merged 2 commits into from Oct 18, 2017
Merged

Conversation

@joschi
Copy link
Contributor

@joschi joschi commented Oct 18, 2017

The functions for numeric conversions, to_long() and to_double(), didn't properly support converting from strings or other numeric types.

Refs https://community.graylog.org/t/graylog-pipeline-problem/2810

The functions for numeric conversions, `to_long()` and `to_double()`, didn't properly
support converting from strings or other numeric types.

Refs https://community.graylog.org/t/graylog-pipeline-problem/2810
@joschi joschi added this to the 3.0.0 milestone Oct 18, 2017
@joschi joschi requested a review from kroepke Oct 18, 2017
@ghost ghost assigned joschi Oct 18, 2017
Copy link
Member

@kroepke kroepke left a comment

lgtm!

@kroepke kroepke merged commit 986cda5 into master Oct 18, 2017
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
@garybot2
graylog-project/pr Jenkins build graylog-project-pr-snapshot 616 has succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@kroepke kroepke deleted the numeric-conversions branch Oct 18, 2017
@ghost ghost removed the ready-for-review label Oct 18, 2017
kroepke added a commit that referenced this pull request Oct 18, 2017
* Fix numeric conversions with to_double()/to_long()

The functions for numeric conversions, `to_long()` and `to_double()`, didn't properly
support converting from strings or other numeric types.

Refs https://community.graylog.org/t/graylog-pipeline-problem/2810

* Add test cases for numeric corner cases (min/max/infinity)

(cherry picked from commit 986cda5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants