New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IpAddressConversion caught wrong exception #32

Merged
merged 1 commit into from May 17, 2016

Conversation

Projects
None yet
2 participants
@kroepke
Member

kroepke commented May 17, 2016

the first try block caught a too specific version of the IllegalArgumentException, allowing the exception to unwind too much.
properly return null or the default value in this case.

fix issue #28

IpAddressConversion caught wrong exception
the first try block caught a too specific version of the IllegalArgumentException, allowing the exception to unwind too much.
properly return null or the default value in this case.

fix issue #28

@kroepke kroepke added this to the 1.0.0 milestone May 17, 2016

@joschi joschi self-assigned this May 17, 2016

@joschi joschi merged commit fc5b8a5 into 1.0 May 17, 2016

@joschi

This comment has been minimized.

Contributor

joschi commented May 17, 2016

LGTM. 👍

@joschi joschi deleted the issue-28 branch May 17, 2016

kroepke added a commit that referenced this pull request Jul 20, 2016

IpAddressConversion caught wrong exception (#32)
The first try block caught a too specific version of the IllegalArgumentException, allowing the exception to unwind too much. Properly return null or the default value in this case.

Fixes #28
(cherry picked from commit fc5b8a5)

edmundoa added a commit that referenced this pull request Jul 22, 2016

Update evalError test rule
Since #32, the behaviour of `to_ip()` changed and now it doesn't raise
an exception in those circumstances. Now we use `regex()` to throw an
exception instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment