Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use raw messages on simulator #42

Merged
merged 4 commits into from Jul 4, 2016
Merged

Use raw messages on simulator #42

merged 4 commits into from Jul 4, 2016

Conversation

@edmundoa
Copy link
Member

@edmundoa edmundoa commented Jun 30, 2016

As simulating the result of already processed messages can become really tricky, this PR replaces the message loader used in the pipeline simulator, using the new raw message loader available in Graylog2/graylog2-server#2438. Therefore, we need to wait merging this until the referring PR is merged into master.

@bernd bernd self-assigned this Jul 1, 2016
@bernd
Copy link
Member

@bernd bernd commented Jul 1, 2016

I am a bit confused by the "Changes summary" saying "Original message would be dropped during processing.". Is that correct?

axvvyf1nwrkaaaaaaelftksuqmcc

The results preview is correct, the hello field got replaced by a rule.

wfe6eorbvrgsaaaaabjru5erkjggg

@edmundoa
Copy link
Member Author

@edmundoa edmundoa commented Jul 1, 2016

Well, it was correct when we were using messages already stored in Graylog, I will update those texts

edmundoa added 2 commits Jun 30, 2016
At this point the pipeline simulator only makes sense for messages that were
not already processed by Graylog, as it can be really tricky to see
changes done in already processed messages. Therefore, we replace the message
loader, using the raw message loader.
@edmundoa edmundoa force-pushed the simulator-raw-messages branch from df3cd3b to 55a14a5 Jul 1, 2016
edmundoa added 2 commits Jul 4, 2016
Receive a message fields instead of the raw message. In this way
we don't have problems comparing message IDs, timestamps, and the API
will work regardless of the message loader being used in the frontend.
@bernd
Copy link
Member

@bernd bernd commented Jul 4, 2016

LGTM 👍

@bernd bernd merged commit 8f6cc74 into master Jul 4, 2016
@bernd bernd deleted the simulator-raw-messages branch Jul 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants